[Bugfix] Support substitution events with no replacement player #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If there is no other player coming on the pitch, it should not be counted as a subsitution, right? In Stats Perform data, these should be "Player retired" events. Do you know why the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in our StatsPerform deserializer we potentially set the replacement_player as None in case the player off event is not directly followed by a player on event, which happens in approx 1% of the matches, see: https://github.com/PySport/kloppy/blob/master/kloppy/infra/serializers/event/statsperform/deserializer.py#L396-L406.
In order to support substitution events where no new sub on player is coming on the pitch for the sub off player, we add a check to see whether the replacement player actually exists prior to updating its position.
For context, a related discussion on substitution events: #362.